summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSebastian Rasmussen <sebras@gmail.com>2025-04-20 04:27:24 +0200
committerSebastian Rasmussen <sebras@gmail.com>2025-04-21 18:44:28 +0200
commit9a3129e5c1edca7bd90f932b51488ff557ed448f (patch)
treec137a1c9ca4caf77683272f81113944e09204806
parent10bad60cf19afbca470db70a31097f8ca3b89e2e (diff)
js/java/docs: Rename StrokeState.getDashes to getDashPattern.
This better describes what it is and matches with the specification.
-rw-r--r--docs/src/changes.rst1
-rw-r--r--docs/src/mutool-object-stroke-state.rst26
-rw-r--r--platform/java/jni/strokestate.c2
-rw-r--r--platform/java/mupdf_native.h4
-rw-r--r--platform/java/src/com/artifex/mupdf/fitz/StrokeState.java2
-rw-r--r--source/tools/murun.c6
6 files changed, 33 insertions, 8 deletions
diff --git a/docs/src/changes.rst b/docs/src/changes.rst
index c930e639a..b4e861e69 100644
--- a/docs/src/changes.rst
+++ b/docs/src/changes.rst
@@ -43,6 +43,7 @@ Changes from 1.25 to 1.26
- `PDFAnnotation.setFilespec` renamed `PDFAnnotation.setFileSpec`
- `PDFDocument.getFilespecParams` renamed `PDFDocument.getFileSpecParams`.
- `PDFObject.isFilespec` renamed `PDFObject.isFileSpec`.
+- `StrokeState.getDashes` renamed `StrokeState.getDashPattern`.
Changes from 1.24 to 1.25
diff --git a/docs/src/mutool-object-stroke-state.rst b/docs/src/mutool-object-stroke-state.rst
index a3d177485..8b94c076f 100644
--- a/docs/src/mutool-object-stroke-state.rst
+++ b/docs/src/mutool-object-stroke-state.rst
@@ -36,7 +36,7 @@ A `StrokeState` object is used to define stroke styles.
lineWidth: 1.5,
miterLimit: 10.0,
dashPhase: 0,
- dashes: [ 4, 8 ],
+ dashPattern: [ 4, 8 ],
})
@@ -91,3 +91,27 @@ A `StrokeState` object is used to define stroke styles.
.. code-block:: javascript
var limit = strokeState.getMiterLimit();
+
+.. method:: getDashPhase()
+
+ |mutool_tag|
+
+ :return: `Float`.
+
+ |example_tag|
+
+ .. code-block:: javascript
+
+ var limit = strokeState.getDashPhase();
+
+.. method:: getDashPattern()
+
+ |mutool_tag|
+
+ :return: [ `Float`, `Float`, ... ].
+
+ |example_tag|
+
+ .. code-block:: javascript
+
+ var dashPattern = strokeState.getDashPattern();
diff --git a/platform/java/jni/strokestate.c b/platform/java/jni/strokestate.c
index da4857b4e..06f2151ce 100644
--- a/platform/java/jni/strokestate.c
+++ b/platform/java/jni/strokestate.c
@@ -104,7 +104,7 @@ FUN(StrokeState_getDashPhase)(JNIEnv *env, jobject self)
}
JNIEXPORT jfloatArray JNICALL
-FUN(StrokeState_getDashes)(JNIEnv *env, jobject self)
+FUN(StrokeState_getDashPattern)(JNIEnv *env, jobject self)
{
fz_context *ctx = get_context(env);
fz_stroke_state *stroke = from_StrokeState(env, self);
diff --git a/platform/java/mupdf_native.h b/platform/java/mupdf_native.h
index 71858ad02..2d1d341c8 100644
--- a/platform/java/mupdf_native.h
+++ b/platform/java/mupdf_native.h
@@ -6965,10 +6965,10 @@ JNIEXPORT jfloat JNICALL Java_com_artifex_mupdf_fitz_StrokeState_getDashPhase
/*
* Class: com_artifex_mupdf_fitz_StrokeState
- * Method: getDashes
+ * Method: getDashPattern
* Signature: ()[F
*/
-JNIEXPORT jfloatArray JNICALL Java_com_artifex_mupdf_fitz_StrokeState_getDashes
+JNIEXPORT jfloatArray JNICALL Java_com_artifex_mupdf_fitz_StrokeState_getDashPattern
(JNIEnv *, jobject);
#ifdef __cplusplus
diff --git a/platform/java/src/com/artifex/mupdf/fitz/StrokeState.java b/platform/java/src/com/artifex/mupdf/fitz/StrokeState.java
index 0e1c51308..723ee5637 100644
--- a/platform/java/src/com/artifex/mupdf/fitz/StrokeState.java
+++ b/platform/java/src/com/artifex/mupdf/fitz/StrokeState.java
@@ -73,5 +73,5 @@ public class StrokeState
public native float getLineWidth();
public native float getMiterLimit();
public native float getDashPhase();
- public native float[] getDashes();
+ public native float[] getDashPattern();
}
diff --git a/source/tools/murun.c b/source/tools/murun.c
index a52ae27f1..25cd04fbf 100644
--- a/source/tools/murun.c
+++ b/source/tools/murun.c
@@ -2870,7 +2870,7 @@ static void ffi_new_StrokeState(js_State *J)
fz_context *ctx = js_getcontext(J);
fz_stroke_state *stroke = NULL;
- if (js_hasproperty(J, 1, "dashes"))
+ if (js_hasproperty(J, 1, "dashPattern"))
{
int i, n = js_getlength(J, -1);
fz_try(ctx)
@@ -2972,7 +2972,7 @@ static void ffi_StrokeState_getDashPhase(js_State *J)
js_pushnumber(J, stroke->dash_phase);
}
-static void ffi_StrokeState_getDashes(js_State *J)
+static void ffi_StrokeState_getDashPattern(js_State *J)
{
fz_stroke_state *stroke = js_touserdata(J, 0, "fz_stroke_state");
ffi_pusharray(J, stroke->dash_list, stroke->dash_len);
@@ -11642,7 +11642,7 @@ int murun_main(int argc, char **argv)
jsB_propfun(J, "StrokeState.getLineWidth", ffi_StrokeState_getLineWidth, 0);
jsB_propfun(J, "StrokeState.getMiterLimit", ffi_StrokeState_getMiterLimit, 0);
jsB_propfun(J, "StrokeState.getDashPhase", ffi_StrokeState_getDashPhase, 0);
- jsB_propfun(J, "StrokeState.getDashes", ffi_StrokeState_getDashes, 0);
+ jsB_propfun(J, "StrokeState.getDashPattern", ffi_StrokeState_getDashPattern, 0);
}
js_setregistry(J, "fz_stroke_state");